Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix the miss profile metrics for GIN #50914

Merged
merged 1 commit into from
Sep 18, 2024
Merged

[BugFix] Fix the miss profile metrics for GIN #50914

merged 1 commit into from
Sep 18, 2024

Conversation

srlch
Copy link
Contributor

@srlch srlch commented Sep 10, 2024 •
edited
Loading

Fix the miss profile metrics for GIN, pr(#48521) delete the code of the profile metrics for GIN by mistake

Fixes #issue
https://github.com/StarRocks/StarRocksTest/issues/8575

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@srlch srlch requested a review from a team as a code owner September 10, 2024 07:17
@mergify mergify bot assigned srlch Sep 10, 2024
@wyb wyb enabled auto-merge (squash) September 10, 2024 08:05
auto-merge was automatically disabled September 11, 2024 12:55

Head branch was pushed to by a user without write access

@srlch srlch force-pushed the bugfix_gin_miss_profile_metrics branch from 7c74e9a to 533f517 Compare September 11, 2024 12:55
@srlch
[BugFix] Fix the miss profile metrics for GIN
0f4701d 
Fix the miss profile metrics for GIN, pr#48521 delete the code of the profile metrics for GIN by mistake

Signed-off-by: srlch <[email protected]>
@srlch srlch force-pushed the bugfix_gin_miss_profile_metrics branch from 533f517 to 0f4701d Compare September 18, 2024 07:48
@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

❌ fail : 0 / 2 (00.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/exec/pipeline/scan/olap_chunk_source.cpp 0 2 00.00% [676, 677]

@andyziye andyziye merged commit 5eebf0e into StarRocks:main Sep 18, 2024
39 of 40 checks passed
@srlch
Copy link
Contributor Author

srlch commented Sep 18, 2024

https://github.com/Mergifyio backport branch-3.3

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 18, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 18, 2024
@srlch @mergify
[BugFix] Fix the miss profile metrics for GIN (#50914)
a7871e3 
Signed-off-by: srlch <[email protected]>
(cherry picked from commit 5eebf0e)

# Conflicts:
#	be/src/exec/pipeline/scan/olap_chunk_source.cpp
@mergify mergify bot mentioned this pull request Sep 18, 2024
Closed
42 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyb wyb wyb approved these changes

@trueeyu trueeyu trueeyu approved these changes

Assignees

@srlch srlch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@srlch @wyb @trueeyu @andyziye